[Bug 2166379] Review Request: wasi-libc - C library for WebAssembly System Interface

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2166379

Josh Stone <jistone@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|needinfo?(jistone@xxxxxxxxx |
                   |m)                          |



--- Comment #8 from Josh Stone <jistone@xxxxxxxxxx> ---
Hi! Thanks for working on this -- I do have notes. :)

> Requires: %{name}%{?_isa} = %{version}-%{release}

This is problematic, requiring something like "wasi-libc(x86-64) = 19-2.fc37".
There's no resulting %{name} package at all, and especially not for the
particular build isa.

> Provides: %{name}-static  = %{version}-%{release}

This is okay, but for Rust it would be a little nicer to have -static on its
own with just %{wasi_libdir}, as I don't need any headers. Then -devel can
Require -static. Really all rustc needs is crt1-command.o, crt1-reactor.o, and
libc.a, but it's probably not worth breaking it down that far.

I tried to use your package with rustc (forcing past the isa problem above),
and got this error:

    .../libc.a: archive has no index; run ranlib to add one

I've faced that with Rust wasm libraries too, like bug 2002612. My current
solution is to run llvm-ranlib in post:
https://src.fedoraproject.org/rpms/rust/blob/752fe3bcd2d1df989986fc5829445ec937311e74/f/rust.spec#_317

After that, it works! At least, I got a Rust "Hello, World!" running in
wasmtime; I didn't try anything more thorough yet.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2166379
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux