https://bugzilla.redhat.com/show_bug.cgi?id=2166379 --- Comment #10 from Jan Staněk <jstanek@xxxxxxxxxx> --- Spec URL: https://download.copr.fedorainfracloud.org/results/jstanek/wasi-libc/fedora-rawhide-x86_64/05560607-wasi-libc/wasi-libc.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jstanek/wasi-libc/fedora-rawhide-x86_64/05560607-wasi-libc/wasi-libc-19-3.fc39.src.rpm (In reply to Josh Stone from comment #8) > > Requires: %{name}%{?_isa} = %{version}-%{release} > > This is problematic, requiring something like "wasi-libc(x86-64) = > 19-2.fc37". There's no resulting %{name} package at all, and especially not > for the particular build isa. Good catch, copied from guidelines without thinking twice. Removed. > > Provides: %{name}-static = %{version}-%{release} > > This is okay, but for Rust it would be a little nicer to have -static on its > own with just %{wasi_libdir}, as I don't need any headers. Then -devel can > Require -static. Really all rustc needs is crt1-command.o, crt1-reactor.o, > and libc.a, but it's probably not worth breaking it down that far. Split to -static and -devel as suggested. I would avoid any further lang-specific adjustments; one of the goals is for this to be usable across various language runtimes. > I tried to use your package with rustc (forcing past the isa problem above), > and got this error: > > .../libc.a: archive has no index; run ranlib to add one > > I've faced that with Rust wasm libraries too, like bug 2002612. My current > solution is to run llvm-ranlib in post: > https://src.fedoraproject.org/rpms/rust/blob/ > 752fe3bcd2d1df989986fc5829445ec937311e74/f/rust.spec#_317 Now included in the package :) Thanks for the notes, let me know how the current version works for you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2166379 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
