https://bugzilla.redhat.com/show_bug.cgi?id=2169277 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(benson_muite@emai | |lplus.org) | --- Comment #10 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Permissions on files are set properly. Note: See rpmlint output See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_file_permissions ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2 Apache License 2.0", "*No copyright* Apache License 2.0", "Historical Permission Notice and Disclaimer - sell variant [generated file]", "Apache License 2.0", "FSF All Permissive License". 12 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/braille-printer-app/2169277-braille- printer-app/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/cups/braille(cups- filters-braille) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: braille-printer-app-2.0b0^7c80811050-1.fc39.x86_64.rpm braille-printer-app-debuginfo-2.0b0^7c80811050-1.fc39.x86_64.rpm braille-printer-app-debugsource-2.0b0^7c80811050-1.fc39.x86_64.rpm braille-printer-app-2.0b0^7c80811050-1.fc39.src.rpm ============================================ rpmlint session starts =========================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpa7c4rvze')] checks: 31, packages: 4 braille-printer-app.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/cups-brf 700 braille-printer-app.x86_64: E: non-readable /usr/lib/cups/backend/cups-brf 700 ============= 4 packages and 0 specfiles checked; 2 errors, 0 warnings, 2 badness; has taken 1.3 s ============ Rpmlint (debuginfo) ------------------- Checking: braille-printer-app-debuginfo-2.0b0^7c80811050-1.fc39.x86_64.rpm ============================================ rpmlint session starts =========================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpg_3fh147')] checks: 31, packages: 1 ============= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.3 s ============ Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 3 braille-printer-app.x86_64: E: non-standard-executable-perm /usr/lib/cups/backend/cups-brf 700 braille-printer-app.x86_64: E: non-readable /usr/lib/cups/backend/cups-brf 700 3 packages and 0 specfiles checked; 2 errors, 0 warnings, 2 badness; has taken 1.8 s Source checksums ---------------- https://github.com/OpenPrinting/braille-printer-app/archive/7c80811/braille-printer-app-7c80811050bb02377b2cb274a20dc54baee7f078.tar.gz : CHECKSUM(SHA256) this package : 1e4ae40f3953394b4bedc2d07319f153933e867b98dcf2fc8180cd4482bd8d76 CHECKSUM(SHA256) upstream package : 1e4ae40f3953394b4bedc2d07319f153933e867b98dcf2fc8180cd4482bd8d76 Requires -------- braille-printer-app (rpmlib, GLIBC filtered): /usr/bin/bash ImageMagick cups cups-filesystem cups-filters libc.so.6()(64bit) liblouisutdml-utils poppler-utils rtld(GNU_HASH) unzip braille-printer-app-debuginfo (rpmlib, GLIBC filtered): braille-printer-app-debugsource (rpmlib, GLIBC filtered): Provides -------- braille-printer-app: braille-printer-app braille-printer-app(x86-64) cups-filters-braille braille-printer-app-debuginfo: braille-printer-app-debuginfo braille-printer-app-debuginfo(x86-64) debuginfo(build-id) braille-printer-app-debugsource: braille-printer-app-debugsource braille-printer-app-debugsource(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: braille-printer- app-7c80811050bb02377b2cb274a20dc54baee7f078/configure.ac:58 Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2169277 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: PHP, SugarActivity, Ocaml, Ruby, R, Haskell, Java, Perl, fonts, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Comments: a) Freedots https://github.com/mlang/freedots is not yet packaged, but could add extra functionality b) Can BuildRequires: liblouis-devel be added, probably helpful for functionality c) Is git-core required? Perhaps remove -S git from the spec file? See: https://download.copr.fedorainfracloud.org/results/fed500/braille-printer-app/fedora-rawhide-x86_64/05533116-braille-printer-app/braille-printer-app.spec d) Check if need it to build on CentOS, maybe some changes are needed: https://copr.fedorainfracloud.org/coprs/fed500/braille-printer-app/build/5533116/ e) Could tests be added, for example, from the README: /usr/sbin/cupsfilter -m application/vnd.cups-brf -p /etc/cups/ppd/yourprinter.ppd yourdocument.txt > ~/test.brf /usr/sbin/cupsfilter -m image/vnd.cups-ubrl -p /etc/cups/ppd/yourprinter.ppd yourimage.png > ~/test.ubrl -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2169277 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
