https://bugzilla.redhat.com/show_bug.cgi?id=2170204 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx --- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: > Provides: python3-rust2rpm = %{version}-%{release} ---> %py_provides python3-rust2rpm > Provides: python3-rust2rpm-core = %{version}-%{release} ---> %py_provides python3-rust2rpm-core This ensures python3.11-rust2rpm etc. is also provided. > %autosetup -n rust2rpm-%{version} -p1 rust2rpm-%{version} is the default name, maybe consider committing it > %pyproject_buildrequires -t ---> %pyproject_buildrequires %{?with_check:-t} > %check > %if %{with check} > %tox > %endif Consider adding unconditional %pyproject_check_import to %check (requires %pyproject_save_files). If (and only if) you don't add it, please hide the entire %check section in the conditional, to avoid empty %check ("package has %check" will be true, but not tests will run). > %files ... Consider using -f %{pyproject_files} here. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2170204 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
