https://bugzilla.redhat.com/show_bug.cgi?id=2169277 Zdenek Dohnal <zdohnal@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(benson_muite@emai | |lplus.org) --- Comment #11 from Zdenek Dohnal <zdohnal@xxxxxxxxxx> --- (In reply to Benson Muite from comment #10) > Issues: > ======= > - Permissions on files are set properly. > Note: See rpmlint output > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_file_permissions > Explained above - the backend has to be run as root. I tested permissions 744, but rpmlint still complained. Fortunately we have a check for whether the binary is run under root, and if not, it exits, so I can change it - though it is useless. > Generic: > [!]: Package should not use obsolete m4 macros > Note: Some obsoleted macros found, see the attachment. > See: https://fedorahosted.org/FedoraReview/wiki/AutoTools Fixed upstream - I've rebased the package. > [x]: Rpmlint is run on debuginfo package(s). > Note: No rpmlint messages. > [x]: Rpmlint is run on all installed packages. > Note: There are rpmlint messages (see attachment). > [x]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > [x]: Spec file according to URL is the same as in SRPM. > > > > Comments: > a) Freedots https://github.com/mlang/freedots is not yet packaged, but could > add extra functionality I focused on having supported some basic file formats - in case someone is willing to package freedots and maintain it, I can add Recommends to braille-printer-app (I have some memory of it being in Fedora in the past, but was dropped due Java deps iirc). But thanks to that I found out converting musicxml files won't work without it (thought lou_translate does the trick), so I'll remove its filter for now. > b) Can > BuildRequires: liblouis-devel > be added, probably helpful for functionality AFAIK liblouis-devel provides only shared library and the only files which are compiled is cups-brf backend and ubrlto4dot driver, which doesn't use any function from liblouis-devel. Which functionality did you see in braille-printer-app which can be provided by the library? > c) Is git-core required? Perhaps remove -S git from the spec file? See: > https://download.copr.fedorainfracloud.org/results/fed500/braille-printer- > app/fedora-rawhide-x86_64/05533116-braille-printer-app/braille-printer-app. > spec Creating simple git repo in source is a neat feature when working with extracted source tarball - easier to create patches. I'm not going to remove the build dependency. > d) Check if need it to build on CentOS, maybe some changes are needed: > https://copr.fedorainfracloud.org/coprs/fed500/braille-printer-app/build/ > 5533116/ I don't plan to put the package to CentOS Stream, since the list of dependencies is quite long and some packages aren't in CentOS Stream. If someone wants to make it available in EPEL for CentOS Stream 8/9 and has a packager rights, I can make him/her a co-maintainer of such branch. > e) Could tests be added, for example, from the README: > /usr/sbin/cupsfilter -m application/vnd.cups-brf -p > /etc/cups/ppd/yourprinter.ppd yourdocument.txt > ~/test.brf > /usr/sbin/cupsfilter -m image/vnd.cups-ubrl -p /etc/cups/ppd/yourprinter.ppd > yourimage.png > ~/test.ubrl This would need a PPD driver, running cupsd and a document in chroot, which is IMO easier to solve in Fedora CI - I'm planning to create a name space at src.fedoraproject.org/tests namespace and move braille sanity test we have in cups-filters. I have uploaded the newest changes, would you mind checking them? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2169277 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
