https://bugzilla.redhat.com/show_bug.cgi?id=2053822 Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vitaly@xxxxxxxxxxxxxx --- Comment #6 from Vitaly Zaitsev <vitaly@xxxxxxxxxxxxxx> --- > License: BSD The License tag must be in SPDX format: $ license-fedora2spdx 'BSD' Warning: more options on how to interpret BSD. Possible options: ['BSD-1-Clause', 'BSD-2-Clause-FreeBSD', 'BSD-2-Clause-Views', 'BSD-2-Clause', 'BSD-3-Clause-Modification', 'BSD-3-Clause'] {{pick BSD choice}} > ExcludeArch: armv7hl Please use this: ExcludeArch: %{arm} %{ix86} > gpgv2 --quiet --keyring %{SOURCE2} %{SOURCE1} %{SOURCE0} Please switch to %{gpgverify} macro: %{gpgverify} --keyring='%{SOURCE2}' --signature='%{SOURCE1}' --data='%{SOURCE0}' > -DCMAKE_BUILD_TYPE=RelWithDebInfo You can use Release here, because `-g` flag is already present in Fedora build flags. RelWithDebInfo will just duplicate it. > # Their install target is not meant to be used. It installs the binary into > # /usr (not /usr/bin) and installs a bunch of other useless files. I think you should port their CMake build manifest to GNUInstallDirs and send a pull request instead of manually calling install binary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2053822 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
