https://bugzilla.redhat.com/show_bug.cgi?id=2053822 --- Comment #7 from Jonathan S. <js-fedora@xxxxxx> --- > The License tag must be in SPDX format: Done > Please use this: ExcludeArch: %{arm} %{ix86} Done > Please switch to %{gpgverify} macro: Done > You can use Release here, because `-g` flag is already present in Fedora build flags. RelWithDebInfo will just duplicate it. This doesn't work - with just Release (the default IIRC), it'll result in an empty debug package. RelWithDebInfo makes it work. > I think you should port their CMake build manifest to GNUInstallDirs and send a pull request instead of manually calling install binary. That doesn't help with this release, though, so is something for later :). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2053822 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
