https://bugzilla.redhat.com/show_bug.cgi?id=2156932 --- Comment #2 from Mattia Verga <mattia.verga@xxxxxxxxx> --- (In reply to Benson Muite from comment #1) > > Comments: > a) Can you check builds on other architectures in Copr? Aarch64, S390x https://copr.fedorainfracloud.org/coprs/mattia/Astronomy/build/5518906/ > b) Could > http://celestrak.com/publications/AIAA/2006-6753/AIAA-2006-6753.zip > be used for the library rather than bundling the C++ file? Hardly. To unbundle sgp4 code would need to write and provide a Makefile ourselves, since upstream only provides Visual Studio project file. And I'm not going to attempt that, as I don't know how to do that. I should have, however, put a "Provides: bundled()" tag, will fix that. > c) Under what license is > http://celestrak.com/publications/AIAA/2006-6753/AIAA-2006-6753.zip > under? Upstream Python library should probably reference this as the source > of the C++ > code and perhaps cite associated paper. I assume it is Public Domain. From upstream FAQ at https://celestrak.org/publications/AIAA/2006-6753/faq.php : "There is no license associated with the code and you may use it for any purpose—personal or commercial—as you wish. We ask only that you include citations in your documentation and source code to show the source of the code and provide links to the main page, to facilitate communications regarding any questions on the theory or source code." Indeed, python-sgp4 should put a note somewhere to cite source code URL. > d) No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-sgp4 Unversioned python-sgp4 doesn't exist (is empty), so I don't think this is necessary. Let me know if you think it's absolutely necessary to unbundle sgp4, in that case I can retire this review request. Otherwise, I'll ask fedora-legal to review sgp4 license and fix the specfile. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2156932 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
