https://bugzilla.redhat.com/show_bug.cgi?id=2141070 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx CC| |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Taking this review. Initial comments: 1. Remove the "without a vendored C library" part from Summary It's nonsense for Fedora packages, as we wouldn't use vendored C sources anyway. 2. If the upstream project has added a license with newer versions, include that file manually in the package for now (i.e. as %SOURCE1 and cp it into the build directory in %prep). 3. Missing Requires in the -devel subpackage: Requires: pkgconfig(fontconfig) Is missing from the -devel subpackage. If you don't add this, then the package might build fine, but using it in dependent packages will fail because BuildRequires are not transitive. Once the package is imported, you can use a rust2rpm.conf file with these contents to automate this: ``` [DEFAULT] buildrequires = pkgconfig(fontconfig) lib.requires = pkgconfig(fontconfig) ``` 4. The project's metadata claims it's MIT licensed, but headers in source code disagrees (MIT OR Apache-2.0). The metadata seems to be wrong, since the crate looks like a fork of an originally "MIT OR Apache-2.0" licensed Servo sub-project. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2141070 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
