[Bug 2141068] Review Request: rust-test-generator - Rust Test generator: enumerating entries according to file-system pattern and generating a test function for each entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2141068

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx
              Flags|                            |fedora-review?
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx
             Status|NEW                         |ASSIGNED



--- Comment #1 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Taking this review.

Initial comments:

- Please don't ignore big FIXMEs in specs generated by rust2rpm.

In this case, Apache-2.0 license file is missing. Please report this upstream.

- The summary is way too long, please trim it to something sensible like

"Generate test functions for all files matching a pattern" or something like
that (or you can come up with something better - the current description is
kind of confusing and I don't really understand what it's trying to say).


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2141068
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux