[Bug 2141725] Review Request: rust-libadwaita-sys - FFI bindings for libadwaita

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2141725

Fabio Valentini <decathorpe@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |decathorpe@xxxxxxxxx
             Status|NEW                         |POST
              Flags|                            |fedora-review+
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |decathorpe@xxxxxxxxx



--- Comment #3 from Fabio Valentini <decathorpe@xxxxxxxxx> ---
Please don't waste your time on trying to update the gtk-rs stack to v0.16 /
gtk4-rs v0.5 / gstreamer-rs v0.19, as that's probably above your pay grade
(yes, it's not lost on me that I don't get paid for this stuff at all).

The glib / gtk3 / gtk4 / gstreamer bindings are a tangled mess that can only be
updated as a single unit. They're also one of the few groups of Rust packages
that are only ever updated in rawhide, because they break so many things with
each "major" update (gtk-rs 0.15 -> 0.16, in this case), and gtk-rs
applications we ship often need some time to adapt to the new versions.

I will handle the gtk-rs v0.16 + gtk4-rs v0.5 + gstreamer-rs v0.19 mega-update
in F38 once things have settled down, but for now, we'll have to stick with
gtk-rs v0.15 + gtk4-rs v0.4 + gstreamer-rs v0.18.

===

You can add this rust2rpm.conf file to automate adding Build/Requires:

```
[DEFAULT]
buildrequires =
  pkgconfig(libadwaita-1) >= 1.0.0
lib.requires =
  pkgconfig(libadwaita-1) >= 1.0.0
```

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged
  (latest version that is compatible with versions of gtk-rs stack in Fedora is
packaged)
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
  (license manually included from upstream project until it will be included in
crate sources with future versions)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- add @rust-sig with "commit" access as package co-maintainer

- set bugzilla assignee overrides to @rust-sig (optional)

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- track package in koschei for all built branches


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2141725
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux