https://bugzilla.redhat.com/show_bug.cgi?id=2134021 --- Comment #5 from Sandro Mani <manisandro@xxxxxxxxx> --- > I agree that the dependency on pyproject-rpm-macros should be explicit and better yet versioned (somehow). Ok - versioned to make sure that manual intervention is required to make sure that a new version of pyproject-rpm-macros works correctly I presume? > The version of this package seems quite arbitrary. Should it follow the pyproject-rpm-macros version instead? Yes can make sense > %pyproject_buildrequires is missing entirely? Yes, I haven't yet looked into this one TBH. Priority for now is to have a possibility to build packages which don't have setup.py. > There are the following runtime requires hardcoded: > Requires: mingwXX-python3-pip > Requires: mingwXX-python3-setuptools > Requires: mingwXX-python3-wheel > That is against the spirit of PEP 517 which this package mentions in the summary and description. > If you just need a way to build a wheel with setuptools and install it, aren't %py3_build_wheel and %py3_install_wheel better suited for the task? This is probably me lacking a good understanding of python building post setuptools. Ultimately I was just looking to mirror the packaging of native packages, but I'm open to any solution which allows me to build the packages. ------------------ > LICENSE. The original macros are: > Copyright 2019 pyproject-rpm-macros contributors > This one is: > > Copyright (c) 2015 Sandro Mani <manisandro@xxxxxxxxx> > > The year is probably bogus and changing the name seems a bit weird. Sloppiness on my part, I copied the license from rpm-mpi-hooks without realizing that it contained also the copyright line. Obviously the copyright should be the one of the original macros. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2134021 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
