https://bugzilla.redhat.com/show_bug.cgi?id=2134021 --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Random thoughts: ------------------ I agree that the dependency on pyproject-rpm-macros should be explicit and better yet versioned (somehow). ------------------ The version of this package seems quite arbitrary. Should it follow the pyproject-rpm-macros version instead? ------------------ %pyproject_buildrequires is missing entirely? There are the following runtime requires hardcoded: Requires: mingwXX-python3-pip Requires: mingwXX-python3-setuptools Requires: mingwXX-python3-wheel That is against the spirit of PEP 517 which this package mentions in the summary and description. If you just need a way to build a wheel with setuptools and install it, aren't %py3_build_wheel and %py3_install_wheel better suited for the task? ------------------ LICENSE. The original macros are: Copyright 2019 pyproject-rpm-macros contributors This one is: Copyright (c) 2015 Sandro Mani <manisandro@xxxxxxxxx> The year is probably bogus and changing the name seems a bit weird. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2134021 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
