https://bugzilla.redhat.com/show_bug.cgi?id=2131705 --- Comment #2 from Anthony Rabbito <hello@xxxxxxxxxxxxxxxxxx> --- Hi Max thanks for your remarks! > There's new macros for shell completions, and all of the completions directories are owned by filesystem. You can apply this patch[1] to your specfile and see [2] for more information. This is great information. I didn't know thank you. > You reference %{pypi_name}, but that doesn't seem to be defined anywhere in your specfile. Instead of defining that macro, I'd suggest replacing all instances of `%{pypi_name}` with the literal value. Ah yes. I originally tried this with pyp2rpm but realized some of the generation is with the old style macros. > There's no dotref.egg-info file in the archive, and this wouldn't be necessary even if there was. Good point. > The preferred format is %{url}/archive/v%{version}/dotref-%{version}.tar.gz, but meh I'm a fan of conventions +1 Copr Build: https://copr.fedorainfracloud.org/coprs/anthr76/dotref/build/4897386/ Spec URL: https://anthr76.fedorapeople.org/python-dotref/python-dotref.spec SRPM URL: https://anthr76.fedorapeople.org/python-dotref/python-dotref-1.2.4-1.fc37.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2131705 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
