https://bugzilla.redhat.com/show_bug.cgi?id=2131705 Carl George 🤠 <carl@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |carl@xxxxxxxxxx CC| |carl@xxxxxxxxxx --- Comment #3 from Carl George 🤠 <carl@xxxxxxxxxx> --- Howdy Anthony, I recognized your name from Twitter. I can take this review. Based on a quick skimming of the upstream README, this appears to be primarily an application, not a library. Per the guidelines [0] it should be named dotref, not python-dotref. Making that change will also have the pleasant side effect of no longer needing the python3-dotref subpackage, the %_description macro, or the `-n dotref-%{version}` flag for %autosetup. What's the reason for using pytest to run the tests? Upstream uses coverage [1], which we should avoid [2], but a simpler approach that avoids the additional build requirement would be to use `%{python3} -m unittest -v`. [0] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_application_naming [1] https://github.com/ovk/dotref/blob/v1.2.4/Makefile#L5 [2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_linters -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2131705 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
