https://bugzilla.redhat.com/show_bug.cgi?id=2131705 Maxwell G <gotmax@e.email> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gotmax@e.email --- Comment #1 from Maxwell G <gotmax@e.email> --- Here's some drive by feedback: There's new macros for shell completions, and all of the completions directories are owned by filesystem. You can apply this patch[1] to your specfile and see [2] for more information. [1]: https://paste.sr.ht/~gotmax23/ad16ede10a059f561e61ce348dd38eb3abc7a22f [2]: https://pagure.io/packaging-committee/issue/1202 You reference %{pypi_name}, but that doesn't seem to be defined anywhere in your specfile. Instead of defining that macro, I'd suggest replacing all instances of `%{pypi_name}` with the literal value. ``` # Remove bundled egg-info rm -rf %{pypi_name}.egg-info ``` There's no dotref.egg-info file in the archive, and this wouldn't be necessary even if there was. > Source: %{url}/archive/refs/tags/v%{version}/dotref-%{version}.tar.gz The preferred format is %{url}/archive/v%{version}/dotref-%{version}.tar.gz, but meh --- It would be nice if you provided a link to a COPR or Koji scratch build. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2131705 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
