https://bugzilla.redhat.com/show_bug.cgi?id=2126927 --- Comment #2 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 49 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/gap-pkg-standardff/2126927-gap-pkg- standardff/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [?]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/gap-pkg-standardff-0.9.4-1.fc38.x86_64 gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/factors-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findirr-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGF2-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGFp-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFp-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFq-0.9.4-1.fc38.x86_64.debug gap-pkg-standardff-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/gap-pkg-standardff-0.9.4-1.fc38.x86_64 gap-pkg-standardff-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-standardff-doc.noarch: W: no-documentation gap-pkg-standardff-debuginfo.x86_64: W: no-documentation gap-pkg-standardff-debugsource.x86_64: W: no-documentation gap-pkg-standardff-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/gap-pkg-standardff-0.9.4-1.fc38.x86_64 gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/factors-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/factors-0.9.4-1.fc38.x86_64.debug' gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findirr-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findirr-0.9.4-1.fc38.x86_64.debug' gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGF2-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGF2-0.9.4-1.fc38.x86_64.debug' gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGFp-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/findstdirrGFp-0.9.4-1.fc38.x86_64.debug' gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFp-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFp-0.9.4-1.fc38.x86_64.debug' gap-pkg-standardff-debuginfo.x86_64: E: ldd-failed /usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFq-0.9.4-1.fc38.x86_64.debug /usr/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8) ldd: warning: you do not have execution permission for `/usr/lib/debug/usr/lib/gap/pkg/StandardFF/ntl/isirrGFq-0.9.4-1.fc38.x86_64.debug' gap-pkg-standardff-doc.noarch: W: invalid-license GPL-3.0-or-later gap-pkg-standardff-doc.noarch: W: invalid-license OFL-1.1-RFN gap-pkg-standardff-doc.noarch: W: invalid-license AGPL-3.0-only gap-pkg-standardff-debuginfo.x86_64: W: invalid-license GPL-3.0-or-later gap-pkg-standardff.x86_64: W: invalid-license GPL-3.0-or-later gap-pkg-standardff-debugsource.x86_64: W: invalid-license GPL-3.0-or-later gap-pkg-standardff-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz gap-pkg-standardff-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/toggless.js ../../GAPDoc/styles/toggless.js gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/05/771a946ee5c06b3db7dce65d7d269cecf58048 ../../../.build-id/05/771a946ee5c06b3db7dce65d7d269cecf58048 gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/12/09a28f2e5ebbc5be3517464d406bf19f07bca1 ../../../.build-id/12/09a28f2e5ebbc5be3517464d406bf19f07bca1 gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/1b/59a58078087f0d806d7647ba64f12849698a5a ../../../.build-id/1b/59a58078087f0d806d7647ba64f12849698a5a gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/3c/8f66ae70a6ac5e442ed460709a44285c13cdb7 ../../../.build-id/3c/8f66ae70a6ac5e442ed460709a44285c13cdb7 gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/e5/0321abc95de97db9800e72513abeb087bab493 ../../../.build-id/e5/0321abc95de97db9800e72513abeb087bab493 gap-pkg-standardff-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/f4/0f8ce3b08e6961f1e8d0b4c1cf3eaf835f89e6 ../../../.build-id/f4/0f8ce3b08e6961f1e8d0b4c1cf3eaf835f89e6 4 packages and 0 specfiles checked; 8 errors, 35 warnings, 8 badness; has taken 6.0 s Source checksums ---------------- https://github.com/frankluebeck/StandardFF/archive/v0.9.4/StandardFF-0.9.4.tar.gz : CHECKSUM(SHA256) this package : a4e0422d0a74ebd3bd426ffc50f3e27048f8862708469540c0ef85d9cb6292c6 CHECKSUM(SHA256) upstream package : a4e0422d0a74ebd3bd426ffc50f3e27048f8862708469540c0ef85d9cb6292c6 Requires -------- gap-pkg-standardff (rpmlib, GLIBC filtered): gap-core libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libntl.so.44()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) gap-pkg-standardff-doc (rpmlib, GLIBC filtered): gap-online-help gap-pkg-standardff gap-pkg-standardff-debuginfo (rpmlib, GLIBC filtered): gap-pkg-standardff-debugsource (rpmlib, GLIBC filtered): Provides -------- gap-pkg-standardff: gap-pkg-standardff gap-pkg-standardff(x86-64) gap-pkg-standardff-doc: gap-pkg-standardff-doc gap-pkg-standardff-debuginfo: debuginfo(build-id) gap-pkg-standardff-debuginfo gap-pkg-standardff-debuginfo(x86-64) gap-pkg-standardff-debugsource: gap-pkg-standardff-debugsource gap-pkg-standardff-debugsource(x86-64) Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -b 2126927 -m gap Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: PHP, Python, Perl, C/C++, R, Haskell, SugarActivity, Ocaml, fonts, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint gap-pkg-standardff-0.9.4-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 gap-pkg-standardff.src: W: invalid-license GPL-3.0-or-later 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 2.6 s $ rpmlint gap-pkg-standardff-0.9.4-1.fc38.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 gap-pkg-standardff.src: W: invalid-license GPL-3.0-or-later 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.3 s $ rpmlint gap-pkg-standardff-doc-0.9.4-1.fc38.noarch.rpm ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 gap-pkg-standardff-doc.noarch: W: only-non-binary-in-usr-lib gap-pkg-standardff-doc.noarch: W: no-documentation gap-pkg-standardff-doc.noarch: W: invalid-license GPL-3.0-or-later gap-pkg-standardff-doc.noarch: W: invalid-license OFL-1.1-RFN gap-pkg-standardff-doc.noarch: W: invalid-license AGPL-3.0-only gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/chooser.html ../../GAPDoc/styles/chooser.html gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/lefttoc.css ../../GAPDoc/styles/lefttoc.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/manual.css ../../GAPDoc/styles/manual.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/manual.js ../../GAPDoc/styles/manual.js gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/nocolorprompt.css ../../GAPDoc/styles/nocolorprompt.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/ragged.css ../../GAPDoc/styles/ragged.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/rainbow.js ../../GAPDoc/styles/rainbow.js gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/times.css ../../GAPDoc/styles/times.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/toggless.css ../../GAPDoc/styles/toggless.css gap-pkg-standardff-doc.noarch: W: dangling-relative-symlink /usr/lib/gap/pkg/StandardFF/doc/toggless.js ../../GAPDoc/styles/toggless.js 1 packages and 0 specfiles checked; 0 errors, 15 warnings, 0 badness; has taken 0.8 s Comments: a) Waiting for review of Knuth license, though it will likely affect many other packages. b) Might add more information on excluded architectures since %{gap_arches} macro is new c) Assume would need other related packages to be included in Fedora at the same time -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2126927 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
