https://bugzilla.redhat.com/show_bug.cgi?id=2123618 --- Comment #18 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Running Fedora review. In the meantime, I re-read the spec file. > %global pypi_name hatch-fancy-pypi-readme (opinionated, feel free to ignore me) Defining a macro like this and reusing it in the spec file makes the spec file harder to read. Especially since the string hatch_fancy_pypi_readme needs to be used on several places instead. > %autosetup -n hatch_fancy_pypi_readme-%{version} (opinionated, feel free to ignore me) Consider using -p1 here from the beginning, so no change is required when a patch is added from upstream. > # https://github.com/hynek/hatch-fancy-pypi-readme/commit/6c06d7244183c5b71aed905c9950e3206e5f0a9e > sed -i 's/ \"pytest-icdiff\", \"coverage\[toml\]\", //g' pyproject.toml (strongly suggested) Add a human-readable comment that summarizes this change, e.g: # Drop unwanted build dependencies that upstream already dropped > %pyproject_buildrequires -w (strongly suggested) Considering -w is provisional and hatch no longer needs it since https://src.fedoraproject.org/rpms/python-hatchling/pull-request/16 I suggest dropping -w. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2123618 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
