[Bug 2126927] Review Request: gap-pkg-standardff - Standardized generation of finite fields and cyclic subgroups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2126927



--- Comment #3 from Jerry James <loganjerry@xxxxxxxxx> ---
Thank you for the review, Benson.

(In reply to Benson Muite from comment #2)
> [!]: Package is not known to require an ExcludeArch tag.

Only 32-bit x86 is excluded, and this is not only allowed, but encouraged:
https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval

> Comments:
> a) Waiting for review of Knuth license, though it will likely affect many
> other packages.

Right, thanks for prodding Richard about that.

> b) Might add more information on excluded architectures since %{gap_arches}
> macro is new

I'm preparing an update to the GAP packaging guidelines
(https://docs.fedoraproject.org/en-US/packaging-guidelines/GAP/) that will
cover this topic.  I meant to have that ready already, but what can I say?  It
isn't.  I'll try to finish that up tomorrow and get it submitted.

> c) Assume would need other related packages to be included in Fedora at the
> same time

No, this is the only package to be added.  The rest of the GAP stack is getting
updates, some quite significant, but only the 1 new package.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2126927
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux