https://bugzilla.redhat.com/show_bug.cgi?id=2108905 --- Comment #5 from Kalev Lember <klember@xxxxxxxxxx> --- (In reply to Michael Catanzaro from comment #4) > (In reply to Kalev Lember from comment #1) > > Another thing I noticed is that various 4.0 packages seem to be missing > > license files. Can you make sure they match with what's shipped in the 4.1 > > packages? > > > > e.g. > > %files -n webkit2gtk4.1-jsc > > %license _license_files/*JavaScriptCore* > > %{_libdir}/libjavascriptcoregtk-4.1.so.0* > > %dir %{_libdir}/girepository-1.0 > > %{_libdir}/girepository-1.0/JavaScriptCore-4.1.typelib > > > > %files -n webkit2gtk4.0-jsc > > %{_libdir}/libjavascriptcoregtk-4.0.so.18* > > %dir %{_libdir}/girepository-1.0 > > %{_libdir}/girepository-1.0/JavaScriptCore-4.0.typelib > > > > ... where the 4.0 version is missing %license. > > Ah, I guess it's possible for the same file to go into multiple subpackages, > as long as it's identical? OK then. Yes, it's possible to share identical files between subpackages, but that's not what's happening here. The %license macro (when called on a file in the source tree) copies the file to /usr/share/licenses/<binary_package_name>/ So if you have: %files -n webkit2gtk4.0-jsc %license _license_files/*JavaScriptCore* %files -n webkit2gtk4.1-jsc %license _license_files/*JavaScriptCore* it copies _license_files/*JavaScriptCore* to both /usr/share/licenses/webkit2gtk4.0-jsc/ and /usr/share/licenses/webkit2gtk4.1-jsc/ which are different paths. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2108905 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
