https://bugzilla.redhat.com/show_bug.cgi?id=2108905 --- Comment #4 from Michael Catanzaro <mcatanza@xxxxxxxxxx> --- (In reply to Kalev Lember from comment #1) > This seems broadly fine to me. Makes a lot of sense to build all of these > from the same source package. I'd like to see a scratch build succeed before > approving this though, just to make sure it has a chance of building in koji > as the package is just so big. Currently it should succeed on all architectures except s390x, which is broken, see: https://pagure.io/releng/issue/10909 https://pagure.io/releng/issue/10910 > On the same note, maybe you could add the GTK4 version to the spec file > already now, just to see if it's possible to build all 3 versions from the > same package without running into issues with koji builders running out of > memory? It's fine to just '%if 0' it out afterwards if you don't want to > actually ship it yet. It's really up to you how prudent you want to be; we > can always split this up afterwards again if koji can't handle building it. This seems prudent. OK. > Another thing I noticed is that various 4.0 packages seem to be missing > license files. Can you make sure they match with what's shipped in the 4.1 > packages? > > e.g. > %files -n webkit2gtk4.1-jsc > %license _license_files/*JavaScriptCore* > %{_libdir}/libjavascriptcoregtk-4.1.so.0* > %dir %{_libdir}/girepository-1.0 > %{_libdir}/girepository-1.0/JavaScriptCore-4.1.typelib > > %files -n webkit2gtk4.0-jsc > %{_libdir}/libjavascriptcoregtk-4.0.so.18* > %dir %{_libdir}/girepository-1.0 > %{_libdir}/girepository-1.0/JavaScriptCore-4.0.typelib > > ... where the 4.0 version is missing %license. Ah, I guess it's possible for the same file to go into multiple subpackages, as long as it's identical? OK then. > Can you add webkit2gtk3%{?_isa} provides to webkit2gtk4.0? There are packages that do 'Requires: webkit2gtk3%{?_isa}' so we need matching provides here. Sure. > Similarly, can you add all of the webkit2gtk4.0 provides to the existing webkit2gtk3 packages in F35 and F36? People like to use the same spec file that works across all of the branches and that makes things a bit easier for them - that way they can do 'BuildRequires: webkit2gtk4.0-devel' or 'Requires: webkit2gtk4.0%{?_isa}' across all Fedora branches and expect it to work. Sure. > Don't you want to raise the value as you've done lately when Kalev hit the build issues? Nah, I think it just slows things down without increasing robustness. Kalev thinks the builders were dying when processing debuginfo, which is not parallelized. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2108905 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
