https://bugzilla.redhat.com/show_bug.cgi?id=2088450 --- Comment #5 from Jakub Ruzicka <jakub.ruzicka@xxxxxx> --- > I don't like the way it prepares for running. Can just single shell script be run to prepare everything? %post script seems unnecessary complicated. Agreed, I voiced a preference for a single script before, but upstream insists this is the best way to setup things. I'm told the scripts are robust and also work with various states of sysrepo repo. There could be a setup-all.sh or similar wrapper script calling the other 3 scripts, but that seems like an unnecessary extra layer. bind too has multiple files to setup different things. > I think single time systemd unit should run when first starting the server. Check bind package for example of generating rndc.key. > It would not have to switch user manually from those scripts, because systemd has good way to switch to non-privileged User/Group. I see named-setup-rndc.service in bind and other services use it in Wants/After: [Service] Type=oneshot ExecStart=/usr/libexec/generate-rndc-key.sh But I don't understand how this is only run once on first server start as opposed to every server start. 🤔 Isn't that what %post is for? What if I want to use the package in a container without systemd? > Scriptlets setup.sh and remove.sh do quite complicated things. Are those necessary? Again, I agree, but upstream deems them necessary. At least this code is actively used and maintained, which is better than having a poorly maintained duplicate on a package level, no? > Why is not netopeer2-server in sbin directory, when it is a system service? Is it useful also as non-privileged user service? This changed in the latest version, I'll query upstream. > On non-fedora distribution like RHEL, this would try adding sysrepo to root user. But I don't think it creates sysrepo in the first place. > usermod -a -G sysrepo root > > Either remove that and rely on presence of sysusers_create_compat macro. It should work also on 0%{?rhel} >= 8. Maybe 9, I am not sure. Or make it working. This is from upstream packaging for SUSE without sysuser_create_compat, and it seems to work there in the CI... I'll have a look at this, fixing the conditional to %if 0%{?fedora} || 0%{?rhel} >= 8 or removing this altogether in Fedora, but having same spec files in upstream and downstream is always a plus. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2088450 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
