[Bug 2088450] Review Request: netopeer2 - Netopeer2 NETCONF tools suite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2088450



--- Comment #4 from Petr Menšík <pemensik@xxxxxxxxxx> ---
I don't like the way it prepares for running. Can just single shell script be
run to prepare everything? %post script seems unnecessary complicated.
I think single time systemd unit should run when first starting the server.
Check bind package for example of generating rndc.key.
It would not have to switch user manually from those scripts, because systemd
has good way to switch to non-privileged User/Group.

Scriptlets setup.sh and remove.sh do quite complicated things. Are those
necessary?

Why is not netopeer2-server in sbin directory, when it is a system service? Is
it useful also as non-privileged user service?

On non-fedora distribution like RHEL, this would try adding sysrepo to root
user. But I don't think it creates sysrepo in the first place. 
 usermod -a -G sysrepo root

Either remove that and rely on presence of sysusers_create_compat macro. It
should work also on 0%{?rhel} >= 8. Maybe 9, I am not sure. Or make it working.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2088450
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux