https://bugzilla.redhat.com/show_bug.cgi?id=2028900 --- Comment #12 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- Spec URL: https://alebastr.fedorapeople.org/review/tree-sitter-cli/rust-tree-sitter-cli.spec SRPM URL: https://alebastr.fedorapeople.org/review/tree-sitter-cli/rust-tree-sitter-cli-0.20.6-1.fc36.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/3938868 The patch was already sent to upstream in the bindgen PR, but I just made another PR for all accumulated architecture support fixes[1] and an issue[2] for the only remaining failure. > I also wonder if you could replace this: > With setting INCLUDEDIR or something like that to the path of the tree-sitter sources that are bundled with rust-tree-sitter anyway. Yup, good idea. Nothing there needs the shared library from libtree-sitter anyways and it's better to match the headers used for tests with the bundled library source. Replaced with an extremely evil symlink to %{cargo_registry}/tree-sitter-... and left an explanation with source code link. It really has to be done that way :( I'm open to ideas on replacing a lovely reference to '../lib'[3] with a path to another crate's source. I had no luck searching for a code snippet or library :) > This file seems to be missing from the SRPM. I don't think it's worth adding the file to the SRPM as it doesn't participate in the build and I just added a licensing summary. I'm going to keep the file in dist-git though. Does that sound fine? > Please exclude the npm / NodeJS files (npm/, emscripten-version) from getting installed with the -devel package, and investigate whether you need the "vendor/xterm-colors.json" file. emscripten-version[4] and vendors/xterm-colors.json[5] both are necessary for building the crate. npm/ is unused though, so I'm removing it now. Other changes: - updated to 0.20.6 as we're no longer care about the libtree-sitter version (well, mostly...) - added %ifarch conditionals for a test that requires nodejs [1]: https://github.com/tree-sitter/tree-sitter/pull/1692 [2]: https://github.com/tree-sitter/tree-sitter/issues/1693 [3]: https://github.com/tree-sitter/tree-sitter/blob/ccd6bf554d922596ce905730d98a77af368bba5c/cli/src/tests/helpers/dirs.rs#L4 [4]: https://github.com/tree-sitter/tree-sitter/blob/ccd6bf554d922596ce905730d98a77af368bba5c/cli/build.rs#L19 [5]: https://github.com/tree-sitter/tree-sitter/blob/ccd6bf554d922596ce905730d98a77af368bba5c/cli/src/highlight.rs#L44 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2028900 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
