https://bugzilla.redhat.com/show_bug.cgi?id=2070881 --- Comment #1 from Fabio Alessandro Locati <me@xxxxxxx> --- Hi Carmelo, Thanks for the effort, and overall a good package! I see a couple of things to tweak before it's approvable: 1. For future request, please provide direct links and not links that require clicking around (not only for the SPEC, but also for the SRPM) 2. It seems like you were trying to use %autorelease and %autochangelog, but positioned them in the wrong place. * %autochangelog should be put in place of the "standard" changelog, not after it * %autorelease should be used as a parameter for "Release:", like: Release: %autorelease 3. The shipped binary (mockgen) only utility is to generate the source code, so we do not need to have it within the package, since we are already ship the output of it. To strip the binary you should: * Add the configuration to let the builder know to produce platform-independent RPM, since we are only going to ship sources: BuildArch: noarch * Remove the build of the binary: for cmd in mockgen; do %gobuild -o %{gobuilddir}/bin/$(basename $cmd) %{goipath}/$cmd done * Remove the installation of the binary and respective folder: install -m 0755 -vd %{buildroot}%{_bindir} install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/ * Since we only need to put files in the -devel package, we can also remove the whole %file block since %gopkgfiles will take care of all files and put them in the right location without help: %files %license LICENSE %doc AUTHORS CONTRIBUTING.md CONTRIBUTORS README.md sample/README.md %{_bindir}/* -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2070881 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
