https://bugzilla.redhat.com/show_bug.cgi?id=2028900 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review+ --- Comment #13 from Fabio Valentini <decathorpe@xxxxxxxxx> --- > Replaced with an extremely evil symlink to %{cargo_registry}/tree-sitter-... and left an explanation with source code link. It really has to be done that way :( > > I'm open to ideas on replacing a lovely reference to '../lib'[3] with a path to another crate's source. I had no luck searching for a code snippet or library :) Looks good to me. Since those headers are apparently only required for running the test suite, it probably doesn't make sense to tie the version of this crate to tree-sitter-devel version just for that. > I don't think it's worth adding the file to the SRPM as it doesn't participate in the build and I just added a licensing summary. I'm going to keep the file in dist-git though. Does that sound fine? If that's what you want to do, that's fine with me. For some recent packages I updated, I added the file as a "Source" file that I committed it to dist-git, and added it to the binary package with "%license LICENSE.dependencies", but you don't necessarily have to do that. example: https://src.fedoraproject.org/rpms/rust-sequoia-sqv/c/63355b63efe8ed82d1289f11e54ef0fb57b15d72?branch=rawhide > emscripten-version[4] and vendors/xterm-colors.json[5] both are necessary for building the crate. npm/ is unused though, so I'm removing it now. LGTM. > - added %ifarch conditionals for a test that requires nodejs Uh, okay. If you want to keep this complexity, that's up to you. I'd probably just disable that test unconditionally, so I wouldn't have to care about which architectures are supported by NodeJS. === Other than that, the package already looked good, so here's the final review (sorry for the delay): Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide (with latest koji repos) - test suite is run and all unit tests pass (or are reported to upstream) - latest version of the crate is packaged - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - add @rust-sig with "commit" access as package co-maintainer - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2028900 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
