https://bugzilla.redhat.com/show_bug.cgi?id=2028189 --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Olivier Lemasle from comment #1) > - The opam file states that the license is "LGPL-3.0 with OCaml linking > exception"; however, the included LICENSE file states that it is LGPL v2.1 > with exceptions. > Furthermore, the files "src/reactiveData.ml" and "src/reactiveData.mli" > contain a header stating that it uses version v2.1 of LGPL, "or (at your > option) any later version", so "LGPLv2+". > Please clarify the license with upstream. Good catch. I have asked upstream about the license: https://github.com/ocsigen/reactiveData/issues/28 > - Please open a Pull Request on GitHub to upstream your patch, if possible. The patch isn't appropriate for upstream as is. That's the right patch for Fedora, because we have a new enough version of OCaml that the Pervasives to Stdlib move was made. However, upstream may want or need to support older versions of OCaml, prior to that change. The right patch for upstream would involve adding a dependency on stdlib-shims. However, we do not have the stdlib-shims package in Fedora, because we don't need it. Standard practice is to patch out such dependencies, so I would end up patching this package anyway. I can try suggesting the stdlib-shims approach to upstream. I will need a day or two to figure out how to test such a patch, though. > - I'm wondering if the package should not be named ocaml-reactiveData, with > uppercase D (cf > https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > #_case_sensitivity and > https://github.com/ocsigen/reactiveData/blob/0.2.2/pkg/META) I could go either way with the name. The files will be installed to %{_libdir}/ocaml/reactiveData in either case, so the OCaml tools will have the correct name, regardless of what we call the Fedora package. I don't have a strong opinion on the matter, so I'll default to what I already have unless you insist. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2028189 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
