https://bugzilla.redhat.com/show_bug.cgi?id=2028189 Olivier Lemasle <o.lemasle@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Assignee|nobody@xxxxxxxxxxxxxxxxx |o.lemasle@xxxxxxxxx Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED CC| |o.lemasle@xxxxxxxxx --- Comment #1 from Olivier Lemasle <o.lemasle@xxxxxxxxx> --- - The opam file states that the license is "LGPL-3.0 with OCaml linking exception"; however, the included LICENSE file states that it is LGPL v2.1 with exceptions. Furthermore, the files "src/reactiveData.ml" and "src/reactiveData.mli" contain a header stating that it uses version v2.1 of LGPL, "or (at your option) any later version", so "LGPLv2+". Please clarify the license with upstream. - Please open a Pull Request on GitHub to upstream your patch, if possible. - I'm wondering if the package should not be named ocaml-reactiveData, with uppercase D (cf https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_case_sensitivity and https://github.com/ocsigen/reactiveData/blob/0.2.2/pkg/META) Otherwise, - Version packaged is the latest tagged release (0.2.2) - Package builds in mock - Conforms to the Packaging Guidelines and the OCaml Packaging Guidelines Rpmlint results: ocaml-reactivedata-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/ocaml/reactiveData/reactiveData.cmxs-0.2.2-1.fc36.x86_64.debug ocaml-reactivedata-devel.x86_64: E: static-library-without-debuginfo /usr/lib64/ocaml/reactiveData/reactiveData.a ocaml-reactivedata.x86_64: E: shared-library-without-dependency-information /usr/lib64/ocaml/reactiveData/reactiveData.cmxs ocaml-reactivedata-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/ocaml/reactiveData/reactiveData.cmxs-0.2.2-1.fc36.x86_64.debug ocaml-reactivedata-debuginfo.x86_64: W: no-documentation ocaml-reactivedata-debugsource.x86_64: W: no-documentation ocaml-reactivedata-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/ocaml-reactivedata-0.2.2-1.fc36.x86_64/_build/src/reactiveData.ml ocaml-reactivedata-devel.x86_64: E: incorrect-fsf-address /usr/lib64/ocaml/reactiveData/reactiveData.mli ocaml-reactivedata-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/db/1f58092f7a192430959dc33593ca6be0f91cdd ../../../.build-id/db/1f58092f7a192430959dc33593ca6be0f91cdd -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2028189 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
