https://bugzilla.redhat.com/show_bug.cgi?id=2028189 --- Comment #3 from Olivier Lemasle <o.lemasle@xxxxxxxxx> --- (In reply to Jerry James from comment #2) > > - Please open a Pull Request on GitHub to upstream your patch, if possible. > > The patch isn't appropriate for upstream as is. That's the right patch for > Fedora, because we have a new enough version of OCaml that the Pervasives to > Stdlib move was made. However, upstream may want or need to support older > versions of OCaml, prior to that change. The right patch for upstream would > involve adding a dependency on stdlib-shims. However, we do not have the > stdlib-shims package in Fedora, because we don't need it. Standard practice > is to patch out such dependencies, so I would end up patching this package > anyway. Ok, that's perfectly clear. > > - I'm wondering if the package should not be named ocaml-reactiveData, with > > uppercase D (cf > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/ > > #_case_sensitivity and > > https://github.com/ocsigen/reactiveData/blob/0.2.2/pkg/META) > > I could go either way with the name. The files will be installed to > %{_libdir}/ocaml/reactiveData in either case, so the OCaml tools will have > the correct name, regardless of what we call the Fedora package. I don't > have a strong opinion on the matter, so I'll default to what I already have > unless you insist. Ok, that's fine with me. We just have to wait from upstream for the license clarification (the incorrect FSF address is not blocker as soon as upstream is informed: https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address). I hope you'll get an answer, as the GitHub repo does not have much activity lately :-( -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2028189 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
