https://bugzilla.redhat.com/show_bug.cgi?id=2015526 Robby Callicotte <rcallicotte@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcallicotte@xxxxxxxxxxxxxx --- Comment #1 from Robby Callicotte <rcallicotte@xxxxxxxxxxxxxx> --- Hello! I am not a packager yet, so this is an unofficial review... > %files > %license %{golicenses} > %doc %{godocs} > %{_bindir}/* Would %{_bindir}/%{name} be preferable here? It looks like this package will try to own all files under %{_bindir}. > %changelog > %autochangelog This expands to * Tue Oct 19 2021 John Doe <packager@xxxxxxxxxxx> - 0.5.2-1.fc36 - local build The dist tag should not be in the changelog entry. The name/email does not match. ===== MUST items ===== [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: asciigraph-0.5.2-1.fc36.x86_64.rpm golang-github-guptarohit-asciigraph-devel-0.5.2-1.fc36.noarch.rpm asciigraph-0.5.2-1.fc36.src.rpm asciigraph.x86_64: E: statically-linked-binary /usr/bin/asciigraph asciigraph.x86_64: W: no-manual-page-for-binary asciigraph golang-github-guptarohit-asciigraph-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/guptarohit/asciigraph/.goipath asciigraph.src:62: W: macro-in-%changelog %autochangelog 3 packages and 0 specfiles checked; 1 errors, 3 warnings. --Robby -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2015526 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
