https://bugzilla.redhat.com/show_bug.cgi?id=2015526 --- Comment #2 from Major Hayden 🤠 <mhayden@xxxxxxxxxx> --- (In reply to Robby Callicotte from comment #1) > I am not a packager yet, so this is an unofficial review... Appreciated! > > %files > > %license %{golicenses} > > %doc %{godocs} > > %{_bindir}/* > > Would %{_bindir}/%{name} be preferable here? It looks like this package > will try to own all files under %{_bindir}. It will own only the ones that are created within this package at build time. I mainly do this to keep my spec files somewhat similar between packages. > > %changelog > > %autochangelog > > This expands to > * Tue Oct 19 2021 John Doe <packager@xxxxxxxxxxx> - 0.5.2-1.fc36 > - local build > > The dist tag should not be in the changelog entry. The name/email does not > match. Right. This depends on the package coming from a source git repo so that rpmautospec can generate the changelog based on the git history. Once it's in a source-git repo, this will be populated with the right data. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2015526 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
