https://bugzilla.redhat.com/show_bug.cgi?id=2012522 --- Comment #15 from Maxwell G <gotmax@e.email> --- (In reply to Mikel Olasagasti Uranga from comment #14) > Any reason to have 3 subpackages for shell-completion variants? > > I've check and just a few packages are doing this way while many other just > install the shell-completion files as part of the main package. Hi Mikel, Thank you for asking. I want users to be able to install only the completions for the shell that they use or even no completions at all. I set this up so that, as long as the user hasn't disabled weak deps[1], dnf will automatically install the bash completions only if `bash-completion` is also installed and the same for the other shell completion packages. I got this idea from one of OpenSUSE's packages, and I think it's quite elegant. Another reviewer seemed to agree[2]. > Suggests and Supplements clauses are wisely used Thanks, Maxwell [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/#_weak_dependencies [2]: https://bugzilla.redhat.com/show_bug.cgi?id=2012522#c3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2012522 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
