https://bugzilla.redhat.com/show_bug.cgi?id=2008090 Dan Horák <dan@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |467765 (ZedoraTracker) CC|dan@xxxxxxxx, | |dan.horak@xxxxxxxx | --- Comment #2 from Dan Horák <dan@xxxxxxxx> --- some initial comments - the Source0 value should be an URL, see the Git Hosting Services section in https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ - it's better to use %{build_cflags} / %{build_cxxflags} instead of ${RPM_OPT_FLAGS} - the %post/%postun scriptlets calling ldconfig are not required any more, it's handled by system-wide triggers - you shouldn't package the static library unless really needed and if needed, then it belongs to a "static" subpackage, see https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries - we can't move the baseline arch for Fedora to z >= 14 any time soon, can the library gracefully shutdown the app when run on z < 14? We should avoid a situation when an app will suddenly crash with a SIGILL. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=467765 [Bug 467765] Fedora for System z (s390): Bug Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2008090 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
