https://bugzilla.redhat.com/show_bug.cgi?id=2008090 --- Comment #3 from Andreas Krebbel <krebbel1@xxxxxxxxxx> --- (In reply to Dan Horák from comment #2) > some initial comments Thanks! I've just uploaded a new version addressing most of your comments. > - the Source0 value should be an URL, see the Git Hosting Services section > in https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Ok. I'll fix it once we have a release tag in the github repo. We will have that within the next couple of days. > - it's better to use %{build_cflags} / %{build_cxxflags} instead of > ${RPM_OPT_FLAGS} Done > - the %post/%postun scriptlets calling ldconfig are not required any more, > it's handled by system-wide triggers Done > - you shouldn't package the static library unless really needed and if > needed, then it belongs to a "static" subpackage, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static- > libraries Some scenarios might require a static version of the lib. I've moved it into a separate package. > - we can't move the baseline arch for Fedora to z >= 14 any time soon, can > the library gracefully shutdown the app when run on z < 14? We should avoid > a situation when an app will suddenly crash with a SIGILL. The library has some init routines which aren't build with z14 and allow to check whether the specific feature is present or not. It is described in the API that every application has to use these functions before invoking anything else. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2008090 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
