https://bugzilla.redhat.com/show_bug.cgi?id=2007765 Miro Hrončok <mhroncok@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mhroncok@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: > %global pypi_name name-that-hash > %global name_with_underscore name_that_hash > %global name_capitalized Name-That-Hash I strongly suggest not to overengineer the spec file by defining all the macros. Instead, I recommend using the actual values where needed -- it makes the spec file much easier to read and/or debug. > Source0: https://github.com/HashPals/Name-That-Hash/archive/refs/tags/%{version}.tar.gz I suggest using and URL that contains name in the filename, e.g.: Source0: https://github.com/HashPals/Name-That-Hash/archive/%{version}/Name-That-Hash-%{version}.tar.gz > %description > Name That Hash will name that hash type! Identify MD5, SHA256 and 300+ other > hashes Descriptions should end with a period. > %pyproject_buildrequires -r -x tests I don't see any [tests] extra in the package. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2007765 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
