https://bugzilla.redhat.com/show_bug.cgi?id=1999312 Major Hayden 🤠 <mhayden@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mhayden@xxxxxxxxx | |m) | --- Comment #2 from Major Hayden 🤠 <mhayden@xxxxxxxxxx> --- (In reply to Ben Beasley from comment #1) > - Version 2.3.1 was released since you requested review; please update. > > https://github.com/googleapis/python-firestore/compare/v2.3.0...v2.3.1 Done. > - The patch to switch from the deprecated PyPI mock to the standard library’s > unittest.mock should normally be offered upstream at > https://github.com/googleapis/python-firestore/, and the issue or PR should > be linked in a spec file comment. > > > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > PatchUpstreamStatus/ > > In this case, I’ve learned that Python 3.6 and 3.7, which are supported by > upstream, do not have the necessary unittest.mock.AsyncMock class. So it > makes sense to keep this patch downstream-only for now, I suppose, but > please > do add a link to the issue I filed discussing it: > > # Use unittest.mock instead of PyPI backport package mock > # https://github.com/googleapis/python-firestore/issues/445 > Patch0: … Thanks for that. The Google Python folks are working their way up from 2.7 and they have one foot in both worlds. > - If you like, in this case, > > %license LICENSE > > may be removed from > > %files -n python3-%{srcname} > > because pyproject-rpm-macros will take care of marking the license file in > dist-info/egg-info. You do still need the explicit “%license LICENSE” for > the > “doc” subpackage, and no change is required here at all. 👍🏻 > - As of two months ago, > > BuildRequires: pyproject-rpm-macros > > is not required because python3-devel now depends on it. (The BR is not > *wrong*, just superfluous, so no change is required.) Fixed! > - If you like, you could simplify > > %forgesetup > %patch0 -p1 > > as > > %forgeautosetup -p1 Ah, good call. I wasn't aware that there was an autosetup for the forge macros. 🤯 > - Why remove objects.inv from the documentation? This is what would let > another > package’s documentation link to this package’s documentation via > intersphinx, > just as you have done for the Python 3 standard library documentation > (fixing > URL’s in %prep). > > You will get rpmlint messages about invalid encoding or something like that > in objects.inv, because it smells like a text file but isn’t, but those are > spurious. > > See > > https://src.fedoraproject.org/rpms/python-opentelemetry/blob/ > 2007c8d0a3a667dfb67704377b2a9efc35ba9c47/f/python-opentelemetry.spec#_701 > for an example of a package actually using intersphinx links to Python > documentation packages other than python3-docs. It’s not pretty, but it > does > work, and it needs objects.inv to be present in those packages. My sed skills are a bit lacking, so I made a patch instead for the docs that are already packaged. Hopefully that's acceptable. > - Except in cases where certain Sphinx extensions are used (and you’ll get an > error in those cases, so you’ll know) you can parallelize Sphinx > documentation generation using a “-j” flag just like you would use for > make. > So, change > > PYTHONPATH="${PWD}:${PWD}/docs/" sphinx-build docs html > > to > > PYTHONPATH="${PWD}:${PWD}/docs/" sphinx-build docs html %{?_smp_mflags} > > A lot of Python projects (not this one) include a generated Makefile for > Sphinx, in which case this can look something like: > > %make_build -C docs html SPHINXOPTS='%{?_smp_mflags}' Fixed. Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02731201-python-google-cloud-firestore/python-google-cloud-firestore.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02731201-python-google-cloud-firestore/python-google-cloud-firestore-2.3.1-1.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1999312 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
