[Bug 1999312] Review Request: python-google-cloud-firestore - Python Client for Google Cloud Firestore API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1999312

Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |needinfo?(code@musicinmybra
                   |                            |in.net)



--- Comment #3 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> ---
> My sed skills are a bit lacking, so I made a patch instead for the docs that are already packaged. Hopefully that's acceptable.

I think I didn’t communicate clearly. Your original sed expression to fix the
intersphinx inventories was fine. My complaint was just that you were rm’ing
the objects.inv file in %build:

> rm -rf html/.{doctrees,buildinfo} html/objects.inv

and without that file, other packages can’t make intersphinx links to *your*
documentation. My sample spec file with the massive sed command was just an
example to show what *that* might look like, and demonstrate that there are
real packages that do use these local intersphinx inventories.

Feel free to keep it as a patch, or switch back to sed.

-----

I’ll follow up on the re-review shortly.


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=1999312
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux