https://bugzilla.redhat.com/show_bug.cgi?id=1999312 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(mhayden@xxxxxxxxx | |m) --- Comment #1 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - Version 2.3.1 was released since you requested review; please update. https://github.com/googleapis/python-firestore/compare/v2.3.0...v2.3.1 - The patch to switch from the deprecated PyPI mock to the standard library’s unittest.mock should normally be offered upstream at https://github.com/googleapis/python-firestore/, and the issue or PR should be linked in a spec file comment. https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ In this case, I’ve learned that Python 3.6 and 3.7, which are supported by upstream, do not have the necessary unittest.mock.AsyncMock class. So it makes sense to keep this patch downstream-only for now, I suppose, but please do add a link to the issue I filed discussing it: # Use unittest.mock instead of PyPI backport package mock # https://github.com/googleapis/python-firestore/issues/445 Patch0: … - If you like, in this case, %license LICENSE may be removed from %files -n python3-%{srcname} because pyproject-rpm-macros will take care of marking the license file in dist-info/egg-info. You do still need the explicit “%license LICENSE” for the “doc” subpackage, and no change is required here at all. - As of two months ago, BuildRequires: pyproject-rpm-macros is not required because python3-devel now depends on it. (The BR is not *wrong*, just superfluous, so no change is required.) - If you like, you could simplify %forgesetup %patch0 -p1 as %forgeautosetup -p1 - Why remove objects.inv from the documentation? This is what would let another package’s documentation link to this package’s documentation via intersphinx, just as you have done for the Python 3 standard library documentation (fixing URL’s in %prep). You will get rpmlint messages about invalid encoding or something like that in objects.inv, because it smells like a text file but isn’t, but those are spurious. See https://src.fedoraproject.org/rpms/python-opentelemetry/blob/2007c8d0a3a667dfb67704377b2a9efc35ba9c47/f/python-opentelemetry.spec#_701 for an example of a package actually using intersphinx links to Python documentation packages other than python3-docs. It’s not pretty, but it does work, and it needs objects.inv to be present in those packages. - Except in cases where certain Sphinx extensions are used (and you’ll get an error in those cases, so you’ll know) you can parallelize Sphinx documentation generation using a “-j” flag just like you would use for make. So, change PYTHONPATH="${PWD}:${PWD}/docs/" sphinx-build docs html to PYTHONPATH="${PWD}:${PWD}/docs/" sphinx-build docs html %{?_smp_mflags} A lot of Python projects (not this one) include a generated Makefile for Sphinx, in which case this can look something like: %make_build -C docs html SPHINXOPTS='%{?_smp_mflags}' ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Apache License 2.0", "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* [generated file]". 310 files have unknown license. Detailed output of licensecheck in /home/reviewer/1999312-python-google-cloud-firestore/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.10/site- packages/google(python3-google-cloud-core, python3-googleapis-common- protos, python3-google-api-core, python3-google-cloud-iam, python3-google-cloud-storage, python3-google-cloud-functions, python3-google-cloud-redis, python3-google-cloud-build, python3-google-cloud-apigee-connect, python3-google-cloud-billing, python3-grpc-google-iam-v1, python3-google-cloud-billing-budgets, python3-google-cloud-kms, python3-protobuf, python3-google-resumable- media), /usr/lib/python3.10/site-packages/google/cloud(python3-google- cloud-core, python3-google-cloud-iam, python3-google-cloud-storage, python3-google-cloud-redis, python3-google-cloud-functions, python3-google-cloud-build, python3-google-cloud-apigee-connect, python3-google-cloud-billing, python3-google-cloud-billing-budgets, python3-google-cloud-kms), /usr/lib/python3.10/site- packages/google/cloud/__pycache__(python3-google-cloud-core) As far as I can tell, all of these are correctly co-owned as namespace package directories. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 81920 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-google-cloud-firestore [?]: Package functions as described. [!]: Latest version is packaged. Version 2.3.1 is available. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-google-cloud-firestore-2.3.0-1.fc36.noarch.rpm python3-google-cloud-firestore-doc-2.3.0-1.fc36.noarch.rpm python-google-cloud-firestore-2.3.0-1.fc36.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/googleapis/python-firestore/archive/v2.3.0/python-firestore-2.3.0.tar.gz : CHECKSUM(SHA256) this package : cc88a885093acbd9bba647f899468dabb255109ba596e26b03831a9964729bcb CHECKSUM(SHA256) upstream package : cc88a885093acbd9bba647f899468dabb255109ba596e26b03831a9964729bcb Requires -------- python3-google-cloud-firestore (rpmlib, GLIBC filtered): (python3.10dist(google-api-core) < 3~~dev0 with python3.10dist(google-api-core) >= 1.26) (python3.10dist(google-api-core[grpc]) < 3~~dev0 with python3.10dist(google-api-core[grpc]) >= 1.26) (python3.10dist(google-cloud-core) < 3~~dev0 with python3.10dist(google-cloud-core) >= 1.4.1) python(abi) python3.10dist(packaging) python3.10dist(proto-plus) python3-google-cloud-firestore-doc (rpmlib, GLIBC filtered): python3-docs Provides -------- python3-google-cloud-firestore: python-google-cloud-firestore python3-google-cloud-firestore python3.10-google-cloud-firestore python3.10dist(google-cloud-firestore) python3dist(google-cloud-firestore) python3-google-cloud-firestore-doc: python-google-cloud-firestore-doc python3-google-cloud-firestore-doc python3.10-google-cloud-firestore-doc Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1999312 -L /home/reviewer/testutils-dep Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: SugarActivity, Perl, C/C++, fonts, Ocaml, Haskell, R, PHP, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Built with local dependencies: /home/reviewer/testutils-dep/python3-google-cloud-testutils-1.1.0-1.fc36.noarch.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1999312 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
