https://bugzilla.redhat.com/show_bug.cgi?id=1955394 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(code@musicinmybra | |in.net) | --- Comment #38 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- > I've also run rpmlint with a .spec file, it says: > > qatzip.spec:52: W: configure-without-libdir-spec > A configure script is run without specifying the libdir. configure options > must be augmented with something like --libdir=%{_libdir} whenever the script > supports it. > > Indeed, ./configure without --libdir= is called on line 52. Probably, this worth > looking at. This diagnostic is intended for configure scripts that are generated by autoconf, or those that have compatible options. This configure script is hand-written with its own idiosyncratic options, so > --sharedlib-dir=%{_libdir} does the same job. See also https://bugzilla.redhat.com/show_bug.cgi?id=1955394#c4. ----- > For this I would just made necessary changes and pushed them as another commit > without bumping a release and without updating a changelog. I agree. In general, you can feel free to create arbitrary branches and rewrite history in a fork on https://src.fedoraproject.org/, but in the main dist-git repo you should expect to use only the release branches (rawhide/main, f35, f34, …), and to have to live with anything you push there forever. If you make a mistake, bump the release if you’ve built the package with the existing release number, fix the problem, and move forward. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
