https://bugzilla.redhat.com/show_bug.cgi?id=1971512 --- Comment #4 from jiri vanek <jvanek@xxxxxxxxxx> --- > - JNI shared objects MUST be placed in %{_libdir}/%{name}. See: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#JNI quoting: "Java programs that wish to make calls into native libraries do so via the Java Native Interface (JNI). A Java package uses JNI if it contains a .so file. Note that this file can be embedded within JAR files themselves." !Note that this file can be embedded within JAR files themselves.! > Right now the JNI so file is embedded in the jar. > - Please remove RH internal content from the spec. There are two > comments pointing to internal resources. Its not clear how relevant > this is. Thanx. They both are very relevant, and probably the best would be to summ them up in github readme.MD > - Why the criu-devel *runtime* dependency? Right. It is indeed runtime dependence(thats why it is so highlighted), as according to Christine, it is not only header file, but the connector to the criu. I was not investigating more on this topic. > - The source URL doesn't seem to work > $ spectool --gf -S jigawatts.spec > Downloading: > https://github.com/chflood/jigawatts/archive/jigawatts- > c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.zip > Download failed: > 404 Client Error: Not Found for url: > https://codeload.github.com/chflood/jigawatts/zip/jigawatts- > c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e - 0.0 B Elapsed Time: 0:00:00 Sorry, the {uname} macro slipped in. Correct url is https://github.com/chflood/jigawatts/archive/c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.zip Will fix. I hope there will be new tag soon. The tagged version is unusable right now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
