https://bugzilla.redhat.com/show_bug.cgi?id=1971512 --- Comment #3 from Severin Gehwolf <sgehwolf@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - JNI shared objects MUST be placed in %{_libdir}/%{name}. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#JNI Right now the JNI so file is embedded in the jar. - Please remove RH internal content from the spec. There are two comments pointing to internal resources. Its not clear how relevant this is. - Why the criu-devel *runtime* dependency? - The source URL doesn't seem to work $ spectool --gf -S jigawatts.spec Downloading: https://github.com/chflood/jigawatts/archive/jigawatts-c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.zip Download failed: 404 Client Error: Not Found for url: https://codeload.github.com/chflood/jigawatts/zip/jigawatts-c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e - 0.0 B Elapsed Time: 0:00:00 - The latest tagged upstream version is 0.1-alpha, Fedora's version should use a similar scheme. It's currently using '0-0.0.pre.1.c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e' version. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [?]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. Why does jiggawatts depend on criu-devel? Isn't criu sufficient? [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [!]: Useful -debuginfo package or justification otherwise. I believe the shared (JNI) library should have -debuginfo. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/chflood/jigawatts/archive/jigawatts-c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.zip See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: SourceX tarball generation or download is documented. [?]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: Package should compile and build into binary rpms on all supported architectures. Please provide a link to a scratch build [-]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug_package %{nil} [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [?]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: jigawatts-0-0.0.pre.1.c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.fc35.x86_64.rpm jigawatts-javadoc-0-0.0.pre.1.c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.fc35.x86_64.rpm jigawatts-0-0.0.pre.1.c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.fc35.src.rpm jigawatts.x86_64: E: devel-dependency criu-devel jigawatts.x86_64: W: spelling-error %description -l en_US checkpointing -> check pointing, check-pointing, checkpoint jigawatts.x86_64: W: spelling-error %description -l en_US criu -> uric, crib, curium jigawatts.x86_64: E: description-line-too-long C CRIU is a Linux utility that allows the checkpointing and restoring of processes. You can read more about CRIU at criu.org. CRIU for Java is a package which makes it more convenient to use CRIU from Java. jigawatts.x86_64: W: incoherent-version-in-changelog 0.0.1.0-SNAPSHOT ['0-0.0.pre.1.c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.fc35', '0-0.0.pre.1.c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e'] jigawatts.x86_64: E: no-binary jigawatts.x86_64: W: only-non-binary-in-usr-lib jigawatts.src: W: spelling-error %description -l en_US checkpointing -> check pointing, check-pointing, checkpoint jigawatts.src: W: spelling-error %description -l en_US criu -> uric, crib, curium jigawatts.src: E: description-line-too-long C CRIU is a Linux utility that allows the checkpointing and restoring of processes. You can read more about CRIU at criu.org. CRIU for Java is a package which makes it more convenient to use CRIU from Java. jigawatts.src:15: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 15) jigawatts.src: W: invalid-url Source0: https://github.com/chflood/jigawatts/archive/jigawatts-c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.zip HTTP Error 404: Not Found 3 packages and 0 specfiles checked; 4 errors, 8 warnings. Requires -------- jigawatts (rpmlib, GLIBC filtered): (java-headless or java-11-headless) criu-devel java-headless javapackages-filesystem jigawatts-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- jigawatts: jigawatts jigawatts(x86-64) mvn(org.openjdk:jigawatt) mvn(org.openjdk:jigawatt:pom:) jigawatts-javadoc: jigawatts-javadoc jigawatts-javadoc(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
