https://bugzilla.redhat.com/show_bug.cgi?id=1971512 --- Comment #5 from jiri vanek <jvanek@xxxxxxxxxx> --- > [!]: Requires correct, justified where necessary. > Why does jiggawatts depend on criu-devel? Isn't criu sufficient? I'm folloing usptream i this decission. Will add comment. > [x]: Spec file is legible and written in American English. > [-]: Package contains systemd file(s) if in need. > [!]: Useful -debuginfo package or justification otherwise. > I believe the shared (JNI) library should have -debuginfo. I had failed to generate debuginfo for embedded jar. * I have to extract the so from jar - most likely in upstream maven files * or to generate debuginfo for embedded jar, which I do nto know how. In both cases, it is long run. > [x]: Package is not known to require an ExcludeArch tag. > [x]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 10240 bytes in 1 files. > [!]: Package complies to the Packaging Guidelines I must complain - the very same doc you posted as contraindication, I had used as approval: > https://docs.fedoraproject.org/en-US/packaging-guidelines/Java/#JNI quoting: "Java programs that wish to make calls into native libraries do so via the Java Native Interface (JNI). A Java package uses JNI if it contains a .so file. Note that this file can be embedded within JAR files themselves." !Note that this file can be embedded within JAR files themselves.! Anyway, we will find a consensus > > Generic: > [!]: Sources can be downloaded from URI in Source: tag > Note: Could not download Source0: Yas. Unhappy overlook. Will be fixed. > > https://github.com/chflood/jigawatts/archive/jigawatts- > c15dd4c19e81cbcefe419a99ebaa3af7c5c60c5e.zip > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/SourceURL/ > [-]: If the source package does not include license text(s) as a separate > file from upstream, the packager SHOULD query upstream to include it. > [!]: Final provides and requires are sane (see attachments). As above, unless there is more then criu-devel. > [?]: Package functions as described. todo :) But it does something. > [!]: Package should compile and build into binary rpms on all supported > architectures. > Please provide a link to a scratch build Sure! https://koji.fedoraproject.org/koji/taskinfo?taskID=71043006 > [-]: %check is present and all tests pass. > [?]: Packages should try to preserve timestamps of original installed > files. > [!]: Spec use %global instead of %define unless justified. > Note: %define requiring justification: %define debug_package %{nil} That is to skip debuginfo stripping on non-noarch pkg. Tahnx a lot for eyball! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
