https://bugzilla.redhat.com/show_bug.cgi?id=1950985 Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |zebob.m@xxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |zebob.m@xxxxxxxxx Flags| |fedora-review? --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m@xxxxxxxxx> --- - Please add a comment about what this patch does / why it is needed. # apache: use include directory from APXS # On Fedora, when building Apache module support, it is not enough to get # APR CFLAGS, we need also APXS include details. Use APXS tool directly. Patch1: liboauth2-apache-fix.patch - Are you sure you need to ship the static libraries? They are generally not provided in Fedora and should be removed at the end of %install. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries - You must not ship the libtool archives (.la). Remove them at the end of install. rm -vf %{buildroot}%{_libdir}/*.la - Just do this: %dir %{_includedir}/oauth2 %{_includedir}/oauth2/cache.h %{_includedir}/oauth2/cfg.h %{_includedir}/oauth2/http.h %{_includedir}/oauth2/ipc.h %{_includedir}/oauth2/jose.h %{_includedir}/oauth2/log.h %{_includedir}/oauth2/mem.h %{_includedir}/oauth2/oauth2.h %{_includedir}/oauth2/openidc.h %{_includedir}/oauth2/proto.h %{_includedir}/oauth2/session.h %{_includedir}/oauth2/util.h %{_includedir}/oauth2/version.h ⇒ %{_includedir}/oauth2 - This: %license LICENSE %doc README.md should only be shipped once per package combination. Since devel subpackages and static subpackages depend on the main package, these should be only shipped in the main package as a result. - Split your BR one per line and consider using pkgconfig() for your devel dependencies: BuildRequires: automake BuildRequires: check BuildRequires: cmake BuildRequires: gcc BuildRequires: httpd-devel BuildRequires: libtool BuildRequires: make BuildRequires: pkgconfig(cjose) BuildRequires: pkgconfig(jansson) BuildRequires: pkgconfig(libcurl) BuildRequires: pkgconfig(openssl) - Use a more specific name for your archive: Source0: %url/archive/v%{version}/%{name}-%{version}.tar.gz - Dist tag should be: Release: 1%{?dist} - There does not seem to be any tests provided: Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Q5YK8l + umask 022 + cd /builddir/build/BUILD + cd liboauth2-1.4.1 + /usr/bin/make -O -j16 V=1 VERBOSE=1 check /usr/bin/make make[1]: Nothing to be done for 'all'. /usr/bin/make check-TESTS make[2]: Entering directory '/builddir/build/BUILD/liboauth2-1.4.1' ============================================================================ Testsuite summary for liboauth2 1.4.1 ============================================================================ # TOTAL: 0 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ make[2]: Leaving directory '/builddir/build/BUILD/liboauth2-1.4.1' Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain any libtool archives (.la) Note: liboauth2-static : /usr/lib64/liboauth2.la liboauth2-apache-static : /usr/lib64/liboauth2_apache.la See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries - Dist tag is present. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Affero General Public License, Version 3", "GNU Lesser General Public License", "GNU Affero General Public License v3.0 or later". 19 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/liboauth2/review- liboauth2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 61440 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: liboauth2-static, liboauth2-apache-static. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in liboauth2-static , liboauth2-apache-devel , liboauth2-apache-static [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: liboauth2-1.4.1-1.fc35.x86_64.rpm liboauth2-devel-1.4.1-1.fc35.x86_64.rpm liboauth2-static-1.4.1-1.fc35.x86_64.rpm liboauth2-apache-1.4.1-1.fc35.x86_64.rpm liboauth2-apache-devel-1.4.1-1.fc35.x86_64.rpm liboauth2-apache-static-1.4.1-1.fc35.x86_64.rpm liboauth2-debuginfo-1.4.1-1.fc35.x86_64.rpm liboauth2-debugsource-1.4.1-1.fc35.x86_64.rpm liboauth2-1.4.1-1.fc35.src.rpm liboauth2-apache.x86_64: W: spelling-error Summary(en_US) OAuth -> Oath, Coauthor liboauth2-apache.x86_64: W: spelling-error %description -l en_US OAuth -> Oath, Coauthor 9 packages and 0 specfiles checked; 0 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
