[Bug 1950985] Review Request: liboauth2 - library toolset for OAuth 2.x and OpenID Connect clients and servers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1950985



--- Comment #1 from Alexander Bokovoy <abokovoy@xxxxxxxxxx> ---
I ran fedora-review for the package:


This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package does not contain any libtool archives (.la)
  Note: liboauth2-static : /usr/lib64/liboauth2.la liboauth2-apache-static
  : /usr/lib64/liboauth2_apache.la
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#packaging-static-libraries
- Dist tag is present.


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Affero General Public License,
     Version 3", "GNU Affero General Public License v3.0 or later". 20
     files have unknown license. Detailed output of licensecheck in
     /home/abokovoy/src/packages/liboauth2/liboauth2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 61440 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
     present.
     Note: Package has .a files: liboauth2-static, liboauth2-apache-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     liboauth2-static , liboauth2-apache-devel , liboauth2-apache-static
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Package should not use obsolete m4 macros


Rpmlint
-------
Checking: liboauth2-1.4.1-1.fc35.x86_64.rpm
          liboauth2-devel-1.4.1-1.fc35.x86_64.rpm
          liboauth2-static-1.4.1-1.fc35.x86_64.rpm
          liboauth2-apache-1.4.1-1.fc35.x86_64.rpm
          liboauth2-apache-devel-1.4.1-1.fc35.x86_64.rpm
          liboauth2-apache-static-1.4.1-1.fc35.x86_64.rpm
          liboauth2-debuginfo-1.4.1-1.fc35.x86_64.rpm
          liboauth2-debugsource-1.4.1-1.fc35.x86_64.rpm
          liboauth2-1.4.1-1.fc35.src.rpm
liboauth2-apache.x86_64: W: spelling-error Summary(en_US) OAuth -> Oath,
Coauthor
liboauth2-apache.x86_64: W: spelling-error %description -l en_US OAuth -> Oath,
Coauthor
9 packages and 0 specfiles checked; 0 errors, 2 warnings.




Rpmlint (debuginfo)
-------------------
Checking: liboauth2-debuginfo-1.4.1-1.fc35.x86_64.rpm
          liboauth2-apache-debuginfo-1.4.1-1.fc35.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
liboauth2-apache.x86_64: W: spelling-error Summary(en_US) OAuth -> Oath,
Coauthor
liboauth2-apache.x86_64: W: spelling-error %description -l en_US OAuth -> Oath,
Coauthor
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_shutdown
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_log_sink_ctx_get
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_json_decode_object
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_object_iter_value
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_port_set
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_header_add
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_strdup
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_integer_value
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_init
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_object_iter_next
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_cfg_source_token_get_accept_in
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_string_value
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_mem_free
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_array_get
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 ap_get_client_block
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_strnenvcmp
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_cfg_target_get_remote_user_claim
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 ap_auth_name
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_context_set
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 ap_getword_conf
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_scheme_set
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_response_headers_loop
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_cfg_target_pass_get_as_envvars
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_query_get
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_log
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_log_init
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_cfg_target_pass_get_as_headers
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_normalize_header_name
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_mem_alloc
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_parse_form_encoded_params
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_method_set
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 ap_get_server_name_for_url
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_array_size
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_init
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_cfg_target_pass_get_prefix
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_object_iter_key
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_package_string
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_log_sink_create
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_headers_loop
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_response_status_code_get
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_cfg_target_pass_get_authn_header
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 ap_should_client_block
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_json_encode
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_log_sink_level_set
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 ap_run_http_scheme
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_hostname_set
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_stradd
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_free
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_log_free
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_query_set
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 ap_setup_client_block
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 oauth2_http_request_path_set
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_object_iter
liboauth2-apache.x86_64: W: undefined-non-weak-symbol
/usr/lib64/liboauth2_apache.so.0.0.0 json_object_get
liboauth2-apache.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liboauth2_apache.so.0.0.0 /lib64/libcrypt.so.2
liboauth2-apache.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liboauth2_apache.so.0.0.0 /lib64/libexpat.so.1
liboauth2-apache.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liboauth2_apache.so.0.0.0 /lib64/libldap_r-2.4.so.2
liboauth2-apache.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liboauth2_apache.so.0.0.0 /lib64/liblber-2.4.so.2
liboauth2-apache.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liboauth2_apache.so.0.0.0 /lib64/libpthread.so.0
liboauth2-apache.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liboauth2_apache.so.0.0.0 /lib64/libdl.so.2
liboauth2.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/liboauth2.so.0.0.0 /lib64/libssl.so.1.1
9 packages and 0 specfiles checked; 0 errors, 63 warnings.



Source checksums
----------------
https://github.com/zmartzone/liboauth2/archive/refs/tags/v1.4.1.tar.gz :
  CHECKSUM(SHA256) this package     :
edd1544dd86c4093a01029d555e5d546aa443aba44da3a36a9d65d6731dd84aa
  CHECKSUM(SHA256) upstream package :
edd1544dd86c4093a01029d555e5d546aa443aba44da3a36a9d65d6731dd84aa


Requires
--------
liboauth2 (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libcjose.so.0()(64bit)
    libcrypto.so.1.1()(64bit)
    libcrypto.so.1.1(OPENSSL_1_1_0)(64bit)
    libcurl.so.4()(64bit)
    libjansson.so.4()(64bit)
    libssl.so.1.1()(64bit)
    rtld(GNU_HASH)

liboauth2-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    liboauth2(x86-64)
    liboauth2.so.0()(64bit)
    pkgconfig(jansson)
    pkgconfig(libcrypto)

liboauth2-static (rpmlib, GLIBC filtered):
    liboauth2-devel(x86-64)

liboauth2-apache (rpmlib, GLIBC filtered):
    libapr-1.so.0()(64bit)
    libaprutil-1.so.0()(64bit)
    libc.so.6()(64bit)
    libcrypt.so.2()(64bit)
    libdl.so.2()(64bit)
    libexpat.so.1()(64bit)
    liblber-2.4.so.2()(64bit)
    libldap_r-2.4.so.2()(64bit)
    liboauth2(x86-64)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

liboauth2-apache-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    liboauth2-apache(x86-64)
    liboauth2-devel(x86-64)
    liboauth2_apache.so.0()(64bit)
    pkgconfig(apr-1)
    pkgconfig(apr-util-1)
    pkgconfig(liboauth2)

liboauth2-apache-static (rpmlib, GLIBC filtered):
    liboauth2-apache-devel(x86-64)

liboauth2-debuginfo (rpmlib, GLIBC filtered):

liboauth2-debugsource (rpmlib, GLIBC filtered):



Provides
--------
liboauth2:
    liboauth2
    liboauth2(x86-64)
    liboauth2.so.0()(64bit)

liboauth2-devel:
    liboauth2-devel
    liboauth2-devel(x86-64)
    pkgconfig(liboauth2)

liboauth2-static:
    liboauth2-static
    liboauth2-static(x86-64)
    libtool(/usr/lib64/liboauth2.la)

liboauth2-apache:
    liboauth2-apache
    liboauth2-apache(x86-64)
    liboauth2_apache.so.0()(64bit)

liboauth2-apache-devel:
    liboauth2-apache-devel
    liboauth2-apache-devel(x86-64)
    pkgconfig(liboauth2_apache)

liboauth2-apache-static:
    liboauth2-apache-static
    liboauth2-apache-static(x86-64)
    libtool(/usr/lib64/liboauth2_apache.la)

liboauth2-debuginfo:
    debuginfo(build-id)
    liboauth2-debuginfo
    liboauth2-debuginfo(x86-64)

liboauth2-debugsource:
    liboauth2-debugsource
    liboauth2-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -v -rn
/home/abokovoy/rpmbuild/SRPMS/liboauth2-1.4.1-1.fc34.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, C/C++
Disabled plugins: Perl, Haskell, Java, PHP, fonts, Python, SugarActivity, R,
Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux