https://bugzilla.redhat.com/show_bug.cgi?id=1950985 --- Comment #3 from Alexander Bokovoy <abokovoy@xxxxxxxxxx> --- Thank you for the review, it is helpful. I removed static variants as you suggested, we indeed don't need them. I fixed the rest as well except contracting the include files because there is an explicit split to have /usr/include/oauth2/apache.h in a separate subpackage. I did instead created a file list and filtered apache.h out of it. Once ngnix packaging in Fedora will allow building modules dynamically, I will only need to filter out nginx.h to add support for it. Tests were not running because 'check' dependency is not enough, we need 'pkgconfig(check)' as well. ... checking for CHECK... yes ... make[1]: Leaving directory '/builddir/build/BUILD/liboauth2-1.4.1' /usr/bin/make check-TESTS make[2]: Entering directory '/builddir/build/BUILD/liboauth2-1.4.1' PASS: check_liboauth2 make[2]: Leaving directory '/builddir/build/BUILD/liboauth2-1.4.1' make[2]: Entering directory '/builddir/build/BUILD/liboauth2-1.4.1' ============================================================================ Testsuite summary for liboauth2 1.4.1 ============================================================================ # TOTAL: 1 # PASS: 1 # SKIP: 0 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ============================================================================ make[2]: Leaving directory '/builddir/build/BUILD/liboauth2-1.4.1' A new spec file can be picked from https://download.copr.fedorainfracloud.org/results/abbra/oauth2-support/fedora-rawhide-x86_64/02141226-liboauth2/liboauth2.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
