https://bugzilla.redhat.com/show_bug.cgi?id=1919639 Otto Urpelainen <oturpe@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #23 from Otto Urpelainen <oturpe@xxxxxx> --- Some findings from review. This list is not exhaustive, since I did not have time to go through everything yet, and there were also some items from fedora-review that I still have to look up (everybody is learning something here): - Patch should have link to upstream fix, or comment explaining why it is required but cannot be upstreamed. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ > Patch: s390x-mem.patch - Customarily, changelog entries have a blank line between them (not required as such, but that is what is commonly done). Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#changelogs - For the .desktop file, either desktop-file-install (in %install) OR desktop-file-validate (in %check or %install) must be run. Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files - AppStream .metainfo.xml must be validated with appstream-util validate-relax (in %check or %install). Reference: https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ - Description and summary should be available in all supported languages. I see some translations in the .desktop file, do those count as "supported languages"? Reference: Unclear where this comes from, I cannot find this is Packaging Guidelines, still fedora-review lists this as a SHOULD item. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
