[Bug 1919639] Review Request: DOSBox-X - DOS/x86 emulator

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1919639



--- Comment #22 from Otto Urpelainen <oturpe@xxxxxx> ---
Note that the source stripping can be done without changes upstream. If you
check the correct old commit of Calibre package [1] (incorrectly linked above,
my mistake, I am sorry for that) I linked before, you will find the following
scheme:

  1. The spec file refers to a source tarball that is a stripped down version
of the upstream tarball
  2. The is a comment in spec file explaining which script needs to be run the
create the stripped down tarball
  3. Said script in included in the repository

Similar scheme could be used here to transform upstream sources to smaller
source to be used as a starting point for Fedora packaging. Of course, it would
be great for Fedora if upstream provided a tarball without bundled dependencies
or material specific to other OSes or build systems Fedora does not use — but
there is also the method described above. 

I can also suggest yet another, perhaps simpler way to get started with
stripping: If unnecessary files can be removed like this in the %prep section:

    %prep
    rm -rf vs2015
    # more removals

After that, the removed files do not exist for the rest of processing, and
fedora-review is also smart enough to not consider when checking for licenses.
That way, you could find a suitably simple base. Afterwards, the source
stripping script described above could be developed to make the source rpm
smaller and simplify the licensing situation there also.

I hope this explanation makes sense. Feel free to ask further questions if
anything is unclear.

[1]:
https://src.fedoraproject.org/rpms/calibre/tree/fea70390a1a085be6155894425c353922861bc18


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux