https://bugzilla.redhat.com/show_bug.cgi?id=1919688 --- Comment #3 from Ville-Pekka Vainio <vpvainio@xxxxxx> --- Updated spec: https://vpv.fedorapeople.org/packages/voikko-fi.spec Updated SRPM: https://vpv.fedorapeople.org/packages/voikko-fi-2.4-2.fc33.src.rpm (In reply to Miro Hrončok from comment #2) > 1. BuildRequires: python3 -> please BR python3-devel for Python packages, > even if it is technically not needed. This package is a bit different. It is not a Python package, it just uses a Python script to build the binary data files from the sources. Python is used like this: python3 vvfst/generate_taivutuskaavat.py --destdir=vvfst python3 vvfst/generate_lex.py --destdir=vvfst etc. I believe I don't need to require python3-devel for running these scripts, or do I? > 2. Please avoid <= in obsoletes, it is confusing, since no package is > actually versioned 1.19-20, it is usually 1.19-20.fc34 or similar. Use: > # This package replaces malaga-suomi-voikko > Provides: malaga-suomi-voikko = %{version}-%{release} > Obsoletes: malaga-suomi-voikko < 1.19-21 Ok. The current version in Rawhide is 1.19-13. I'd like to keep the Obsoletes version in 1.19-20 just because it's a nice round number. Is that ok? > 3. Using /usr/lib/voikko is fine, as recommended by Zbyszek, but in the > specfile, please use macros, in this case, it is %{_prefix}/lib/voikko. Fixed. > 4. %doc ChangeLog CONTRIBUTORS COPYING README.md > > Please move COPYING to %license instead of %doc. See > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/#_license_text Fixed. > 5. Listing the entire /usr/lib/voikko directory in %files seems odd to me. > Should that directory not be owned by libvoikko? I guess it's a matter of taste. Technically one could use the library without that specific directory if one set the data file location via an environment variable. If you think it's cleaner to have the directory owned by libvoikko, I can do that. I have updated my local copy of libvoikko.spec accordingly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
