https://bugzilla.redhat.com/show_bug.cgi?id=1919688 --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- Spec sanity: 1. BuildRequires: python3 -> please BR python3-devel for Python packages, even if it is technically not needed. 2. Please avoid <= in obsoletes, it is confusing, since no package is actually versioned 1.19-20, it is usually 1.19-20.fc34 or similar. Use: # This package replaces malaga-suomi-voikko Provides: malaga-suomi-voikko = %{version}-%{release} Obsoletes: malaga-suomi-voikko < 1.19-21 3. Using /usr/lib/voikko is fine, as recommended by Zbyszek, but in the specfile, please use macros, in this case, it is %{_prefix}/lib/voikko. 4. %doc ChangeLog CONTRIBUTORS COPYING README.md Please move COPYING to %license instead of %doc. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text 5. Listing the entire /usr/lib/voikko directory in %files seems odd to me. Should that directory not be owned by libvoikko? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
