https://bugzilla.redhat.com/show_bug.cgi?id=1919688 --- Comment #4 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Ville-Pekka Vainio from comment #3) > > 1. BuildRequires: python3 -> please BR python3-devel for Python packages, > > even if it is technically not needed. > > This package is a bit different. It is not a Python package, it just uses a > Python script to build the binary data files from the sources. > Python is used like this: > python3 vvfst/generate_taivutuskaavat.py --destdir=vvfst > python3 vvfst/generate_lex.py --destdir=vvfst > etc. > > I believe I don't need to require python3-devel for running these scripts, > or do I? You don technically need python3-devel (as I've tried to already say in my initial comment), but it makes our (Python maintainers) queries easier. However, if you are strictly against this, I won't fight you. > > 2. Please avoid <= in obsoletes, it is confusing, since no package is > > actually versioned 1.19-20, it is usually 1.19-20.fc34 or similar. Use: > > > # This package replaces malaga-suomi-voikko > > Provides: malaga-suomi-voikko = %{version}-%{release} > > Obsoletes: malaga-suomi-voikko < 1.19-21 > > Ok. The current version in Rawhide is 1.19-13. I'd like to keep the > Obsoletes version in 1.19-20 just because it's a nice round number. Is that > ok? Totally OK. Also gives you some room for changes in F33. > > 5. Listing the entire /usr/lib/voikko directory in %files seems odd to me. > > Should that directory not be owned by libvoikko? > > I guess it's a matter of taste. Technically one could use the library > without that specific directory if one set the data file location via an > environment variable. > If you think it's cleaner to have the directory owned by libvoikko, I can do > that. I have updated my local copy of libvoikko.spec accordingly. Are there (even theoretically) other packages that will install into that directory? If yes, I'd transfer the ownership to the lib. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
